lkml.org 
[lkml]   [2012]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET] mempool, percpu, blkcg: fix percpu stat allocation and remove stats_lock
On Thu, Feb 23, 2012 at 02:43:36PM -0800, Andrew Morton wrote:
> On Thu, 23 Feb 2012 14:30:38 -0800
> Tejun Heo <tj@kernel.org> wrote:
>
> > This patchset is combination of the patchset "block, mempool, percpu:
> > implement percpu mempool and fix blkcg percpu alloc deadlock" [1] and
> > patches to remove blkg->stats_lock.
>
> What's changed since last time? I scanned the changelogs to see how
> earlier issues were addressed and saw no mention of any of it. eg, is
> the code still deadlockable if the allocator is called with __GFP_WAIT?

Hmmm... going through the thread again, ah, okay, I forgot about that
completely. Yeah, that is an actual problem. Both __GFP_WAIT which
isn't GFP_KERNEL and GFP_KERNEL are valid use cases. I guess we'll be
building async percpu pool in blkcg then. Great. :(

--
tejun


\
 
 \ /
  Last update: 2012-02-24 00:03    [W:0.091 / U:1.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site