lkml.org 
[lkml]   [2012]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC: export constants from shpc.h?
On Thu, 23 Feb 2012 21:50:54 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Feb 23, 2012 at 08:50:04AM -0800, Jesse Barnes wrote:
> > On Thu, 16 Feb 2012 16:54:49 +0200
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > > I've implemented an shpc controller emulator
> > > in qemu, so I needed a bunch of constants
> > > similar to what drivers/pci/hotplug/shpc.h has.
> > >
> > > Any objections to adding a PCI_SHPC_XXXX prefix
> > > so these and moving them to pci_regs.h?
> > > PCI utilities can then use them from /usr/include/linux.
> > >
> > > One can see how a utility that looks at slot LED and MRL
> > > states might be useful
> > > (we'd need to export the base offset through sysfs
> > > to make it possible to use such in parallel with shpc).
> >
> > pci_regs.h is generally reserved for architected regs,
> > but maybe a
> > separate header file makes sense. Or just patch libpciaccess or
> > pci-utils with your tool.
> >
> > --
> > Jesse Barnes, Intel Open Source Technology Center
>
> Fair enough, but out of curiosity,
> could you pls clarify what is meant by 'architected'?
> SHPC is a PCI-SIG spec after all, not a vecor-specific interface...

Sorry that's what I meant; I was thinking it was one of the vendor
ones. Putting the SHPC reg definitions in pci_regs.h is fine.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-02-23 21:03    [W:0.030 / U:21.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site