lkml.org 
[lkml]   [2012]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] linux headers: include linux/types.h where appropriate
On Thu, Feb 23, 2012 at 07:28:10PM +0000, Dave Airlie wrote:
>
> > This silences the related header check warnings.
>
> please fix the bug in the correct place, the drm.h header includes
> linux/types.h and this is one on purpose.
>
> maybe expend some effort fixing the stupid tool to recurse like a normal
> preprocessor would.

Before we fix the tool maybe we should agree on what the tool should check for.
One obvious thing to check is that we do not start to use user-land
types in our exported headers like uint32_t etc.
Another could be that no header file should depend oon the user to include other
header files.
Etc.

The checks we have implmented today are very conservative - but as you resist
to add a few includes in the drm/drm*.h files prevents us from hitting
zero warnings even with these conservative checks.

If we started to be more strict we would see much more warnings/errors.
But all this fuzz about a handfull of includes in the drm header files
sure scare me away from ever starting this.
I can only image the uproar some other changes may cause then.

Sam


\
 
 \ /
  Last update: 2012-02-23 20:53    [W:0.023 / U:33.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site