lkml.org 
[lkml]   [2012]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 20/20] pinctrl: Enhance mapping table to support pin config operations
Linus Walleij wrote at Wednesday, February 22, 2012 11:09 PM:
> On Mon, Feb 20, 2012 at 7:46 AM, Stephen Warren <swarren@nvidia.com> wrote:

...
> > @@ -1022,7 +1074,7 @@ Since it may be common to request the core to hog a few always-applicable
> >  mux settings on the primary pin controller, there is a convenience macro for
> >  this:
> >
> > -PIN_MAP_SYS_HOG("active", "pinctrl-foo", "power_func")
> > +PIN_MAP_MUX_GROUP("pinctrl-foo", "active", "pinctrl-foo", NULL, "power_func")
>
> Please keep the explicit _HOG macros for readability. Relying on
> the implicit relation between dev and pctldev being the same and to be
> parsed by humans is vulnerable.
>
> PIN_MAP_MUX_GROUP_HOG()

OK, I guess I can add some of those back. The main reason I removed the
special-cases was to avoid consumer.h being chock full of a ton of
different macros you had to choose from. This wasn't so much of an issue
before, but since the number of macros has grown now to support pin
config, dummy states, etc., it seemed cluttered.

Still, I guess they're useful, so I can add them back since you asked.

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-02-23 17:51    [W:0.119 / U:10.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site