Messages in this thread |  | | Date | Thu, 23 Feb 2012 07:28:41 +0100 | From | Andreas Bießmann <> | Subject | Re: [PATCH] mod/file2alias: make modpost compile on darwin again |
| |
On 23.02.12 00:08, Rusty Russell wrote: > On Wed, 22 Feb 2012 22:55:35 +0100, Andreas Bießmann <andreas@biessmann.de> wrote: >> commit e49ce14150c64b29a8dd211df785576fa19a9858 breaks cross compiling >> the linux kernel on darwin hosts. >> This fix introduce some minimal glue to adopt linker section handling >> for darwin hosts. > > Really?
Yes.
> Yes, I assumed an ELF host. There's a portable way of doing this, but > it's damn ugly (see http://ccodearchive.net/info/autodata.html).
I stumbled over some other code snippet [1] when searching for a solution.
> Oh, and checkpatch.pl is wrong, the code was fine.
Sorry for that. I was running checkpatch.pl as dutiful patch submitter and that complained. Should I provide another version with 'checkpatch' adoptions changed back?
> If noone has strong opinions about this, I'll apply it.
Would be great. I guess this is a rare case (cross compiling on darwin host) but at least I and some of my colleagues do it from time to time.
Andreas -- [1] http://google-perftools.googlecode.com/svn/!svn/bc/48/trunk/src/base/basictypes.h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |