lkml.org 
[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 02/10] ARM: tegra: export Tegra chipid
    From
    On Mon, Feb 20, 2012 at 3:30 PM, Olof Johansson <olof@lixom.net> wrote:
    > Hi,
    >
    > On Mon, Feb 20, 2012 at 3:13 PM, Colin Cross <ccross@android.com> wrote:
    >
    >> Other platforms use accessors for this (cpu_is_xxx(), although
    >> soc_is_xxx() is probably more appropriate).
    >
    > I have previously objected to additions of said functions on tegra,
    > since they tend to start crawling into drivers as runtime tests
    > instead of providing more appropriate detection at probe time.
    >
    > I can be persuaded differently but I haven't yet seen a strong case
    > for changing my mind. :)

    soc_is_xxx() is better than spreading tegra_chip_id == XXX all over
    the place, but keeping them out of drivers completely is even better.


    \
     
     \ /
      Last update: 2012-02-22 20:23    [W:0.023 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site