Messages in this thread | | | Date | Tue, 21 Feb 2012 22:39:57 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH v2 1/5] x86: Move per cpu cpu_llc_shared_map to a field in struct cpuinfo_x86 |
| |
On 02/21/2012 05:45 PM, Kevin Winchester wrote: > Commit 141168c36cde ("x86: Simplify code by removing a !SMP #ifdefs from > 'struct cpuinfo_x86'") caused the compilation error: > > mce_amd.c:(.cpuinit.text+0x4723): undefined reference to 'cpu_llc_shared_map' > > by removing an #ifdef CONFIG_SMP around a block containing a reference > to cpu_llc_shared_map. Rather than replace the #ifdef, move > cpu_llc_shared_map to be a new cpumask_t field llc_shared_map in > struct cpuinfo_x86 and adjust all references to cpu_llc_shared_map. >
I'm not comfortable with a patch this large after we are already at -rc4. Please send a minimal patch to fix the failure for v3.3, and then a patch on top of that which we can queue up with the rest of the patchset to for v3.4.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |