[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[RESEND][PATCH 2/2] drivers/block/DAC960: fix -Wuninitialized warning
    Set CommandMailbox with memset before use it. Fix for:

    drivers/block/DAC960.c: In function ‘DAC960_V1_EnableMemoryMailboxInterface’:
    arch/x86/include/asm/io.h:61:1: warning: ‘CommandMailbox.Bytes[12]’
    may be used uninitialized in this function [-Wuninitialized]
    drivers/block/DAC960.c:1175:30: note: ‘CommandMailbox.Bytes[12]’
    was declared here

    Signed-off-by: Danny Kukawka <>
    drivers/block/DAC960.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
    index 487ce64..8db9089 100644
    --- a/drivers/block/DAC960.c
    +++ b/drivers/block/DAC960.c
    @@ -1177,7 +1177,8 @@ static bool DAC960_V1_EnableMemoryMailboxInterface(DAC960_Controller_T
    int TimeoutCounter;
    int i;

    + memset(&CommandMailbox, 0, sizeof(DAC960_V1_CommandMailbox_T));
    if (pci_set_dma_mask(Controller->PCIDevice, DMA_BIT_MASK(32)))
    return DAC960_Failure(Controller, "DMA mask out of range");
    Controller->BounceBufferLimit = DMA_BIT_MASK(32);
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-02-22 17:07    [W:0.019 / U:42.572 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site