lkml.org 
[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] CHROMIUM: Input: synaptics - filter out the events with low z values
Hi Daniel,

> > So if num_fingers == 2 and only one of a and b returns
> > finger_touched() == true, we fall back to zero fingers?
>
> Actually, yes. In this case, we will have 2 x's and 2 y's, but not
> know which belong to a good finger and which belong to a too light
> finger.... sigh... synaptics... sigh...

I see the problem. However, ignoring it will just move the problem
forward to another bug report, will it not? Hysteresis is a slam dunk
here. In addition, since the low-pressure state is bound to be
transitional (soon to be followed by a real num_fingers==1 package),
simply skipping such packages might be a better option.

> > Why not introduce hysteresis for all fingers here? There is an example
> > implementation in bcm5974.c in the same directory.
>
> Good idea, can it be in a different, follow-up patch?

Why should it be?

Thanks,
Henrik


\
 
 \ /
  Last update: 2012-02-22 12:07    [W:0.996 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site