Messages in this thread | | | Subject | Re: [PATCH v2 3/3] i387: support lazy restore of FPU state | From | "H. Peter Anvin" <> | Date | Mon, 20 Feb 2012 21:35:16 -0800 |
| |
Running build tests now; will check results in the morning.
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>On Mon, Feb 20, 2012 at 6:14 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> On 02/20/2012 06:10 PM, Linus Torvalds wrote: >>> >>> Although I do wonder if we should just make kernel_fpu_begin() be a >>> real function instead of inlining it. I'm not sure it makes sense to >>> inline that thing, and it might be better to export that one >instead. >>> Comments? >> >> I would agree with that. > >So I have a patch that does that, but it's noticeably bigger. > >It uninlines a fair amount of i387.h, and moves it into i387.c. I do >think it's probably the right thing to do, though. > >I did a "make allmodconfig" with this on x86-64, but it's quite >possible that x86-32 does additional cases. Does this patch work for >people? > >(This is *on*top*of* the quick "let's just get it to work" patch that >just exports the new percpu variable. I already committed that and >pushed it out, since I wanted a quick fix so that people wouldn't be >held up by this) > >IOW, if you can try this on top of current -git, that would be lovely. > > Linus
-- Sent from my mobile phone. Please excuse my brevity and lack of formatting.
| |