lkml.org 
[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/10] mm/memcg: apply add/del_page to lruvec
Many thanks for inspecting these, and so soon.

On Tue, 21 Feb 2012, KAMEZAWA Hiroyuki wrote:
>
> Hmm.. a nitpick.
>
> You do
> lruvec = mem_cgroup_page_lruvec(page, zone);
>
> What is the difference from
>
> lruvec = mem_cgroup_page_lruvec(page, page_zone(page))
>
> ?

I hope they were equivalent: I just did it that way because in all cases
the zone had already been computed, so that saved recomputing it - as I
understand it, in some layouts (such as mine) it's pretty cheap to work
out the page's zone, but in others an expense to be avoided.

But then you discovered that it soon got removed again anyway.

Hugh

>
> If we have a function
> lruvec = mem_cgroup_page_lruvec(page)
>
> Do we need
> lruvec = mem_cgroup_page_lruvec_zone(page, zone)
>
> ?


\
 
 \ /
  Last update: 2012-02-21 23:29    [W:0.099 / U:10.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site