Messages in this thread | | | Subject | Re: [PATCH v2 3/3] i387: support lazy restore of FPU state | From | Suresh Siddha <> | Date | Tue, 21 Feb 2012 14:19:35 -0800 |
| |
On Tue, 2012-02-21 at 13:57 -0800, Linus Torvalds wrote: > On Tue, Feb 21, 2012 at 1:54 PM, Suresh Siddha > <suresh.b.siddha@intel.com> wrote: > > > > Reviewing this code, I think we need to set the 'last_cpu' to an invalid > > number in the fpu_alloc too. Appended is the patch. > > I cleared fpu_counter in copy_thread() instead.
Hmm, didn't pay attention to that patch. Too many patches ;(
> Doing this in fpu_alloc() isn't necessarily a bad idea, though.
yes, I think we should do this in fpu_alloc() or bit more explicitly by updating 'last_cpu' in copy_thread().
Someone experimenting with removing fpu pre-load may not realize this subtle issue.
thanks, suresh
| |