[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 6/10] mm/memcg: take care over pc->mem_cgroup
On Tue, 21 Feb 2012, Konstantin Khlebnikov wrote:
> But just one question: how appears uncharged pages in mem-cg lru lists?

One way is swapin readahead pages, which cannot be charged to a memcg
until they're "claimed"; but we do need them visible on lru, otherwise
memory pressure couldn't reclaim them when necessary.

Another way is simply that uncharging has not historically removed the
page from lru list if it's on. I usually assume that's an optimization:
why bother to get lru locks and take it off (and put it on the root lru?
if we don't, we're assuming it's will be freed very shortly - I'm not
sure that's always a good assumption), if freeing the page will usually
do that for us (without having to change lrus).

If I thought for longer, I might come up with other scenarios.

> Maybe we can forbid this case and uncharge these pages right in
> __page_cache_release() and release_pages() at final removing from LRU.
> This is how my old mem-controller works. There pages in lru are always
> charged.

As things stand, that would mean lock_page_cgroup() has to disable irqs
everywhere. I'm not sure of the further ramifications of moving uncharge
to __page_cache_release() and release_pages(). I don't think a change
like that is out of the question, but it's certainly a bigger change
than I'd like to consider in this series.


 \ /
  Last update: 2012-02-21 20:41    [W:0.089 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site