lkml.org 
[lkml]   [2012]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectUse gcc to check exported files [Was: Linux 3.3-rc4]
    On Tue, Feb 21, 2012 at 01:03:45PM +0000, Alan Cox wrote:
    > > I'm starting to think we should compile the kernel with -Wpadded by
    > > default (currently it's only done at "warning level 3", which I doubt
    > > anyone ever uses, especially since that also includes -Wpacked which is
    > > an actively toxic warning) and force people to add explicit padding
    > > where it needs to go, if necessary. Unfortunately even that doesn't
    > > guarantee compatibility with userspace, but it's at least something.
    >
    > We generate a set of believed correct export headers and check them these
    > days as an option. Can that work not be turned to do this. Ie create a
    > temporary .c file that includes all the user visible header data (without
    > KERNEL being defined) and runs it through -Wpacked etc

    Hi Alan.

    If we require every exported file to be buildable on thier own
    then it is simple to run gcc on every exported file.

    We have before discussed that our header files should include everything
    they need - and at least forcing this for our user-space headers would not be bad.

    Simple hack I cooked up (will not work if you use O=...):

    diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
    index 7957e7a..b479575 100644
    --- a/scripts/headers_check.pl
    +++ b/scripts/headers_check.pl
    @@ -27,12 +27,16 @@ my $line;
    my $lineno = 0;
    my $filename;

    +my $gcc_options = "-Wall -Wpadded";
    +my $gcc_include = "-I usr/include";
    +
    foreach my $file (@files) {
    $filename = $file;

    open(my $fh, '<', $filename)
    or die "$filename: $!\n";
    $lineno = 0;
    + &check_build();
    while ($line = <$fh>) {
    $lineno++;
    &check_include();
    @@ -45,6 +49,13 @@ foreach my $file (@files) {
    }
    exit $ret;

    +# Check that the header-file can build
    +# All exported headers are assumed to include what they need
    +sub check_build
    +{
    + system("gcc -xc -c $gcc_include $gcc_options $filename")
    +}
    +
    sub check_include
    {
    if ($line =~ m/^\s*#\s*include\s+<((asm|linux).*)>/) {

    Now we just need someone to fix up the headers....
    I counted around 870 errors in 160 files.
    But 99% looked trivial to fix...
    Almost all is a matter of adding one or a few missing includes.

    Sam



    \
     
     \ /
      Last update: 2012-02-21 19:29    [W:0.023 / U:0.724 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site