Messages in this thread | | | Date | Tue, 21 Feb 2012 15:21:31 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 4/5] x86: Move per cpu cpu_core_map to a field in struct cpuinfo_x86 |
| |
On Mon, Feb 20, 2012 at 10:06:05PM -0400, Kevin Winchester wrote: > This simplifies the various code paths using this field as it > groups the per-cpu data together. > > Signed-off-by: Kevin Winchester <kjwinchester@gmail.com> > --- > arch/x86/include/asm/processor.h | 2 ++ > arch/x86/include/asm/smp.h | 6 ------ > arch/x86/include/asm/topology.h | 4 ++-- > arch/x86/kernel/cpu/proc.c | 3 +-- > arch/x86/kernel/smpboot.c | 35 ++++++++++++++--------------------- > arch/x86/xen/smp.c | 4 ---- > drivers/cpufreq/acpi-cpufreq.c | 2 +- > drivers/cpufreq/powernow-k8.c | 13 +++---------- > 8 files changed, 23 insertions(+), 46 deletions(-) > > diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h > index 38de3aa..53f7a8c 100644 > --- a/arch/x86/include/asm/processor.h > +++ b/arch/x86/include/asm/processor.h > @@ -115,6 +115,8 @@ struct cpuinfo_x86 { > u16 llc_id; > /* representing HT siblings of each logical CPU */ > cpumask_t sibling_map; > + /* representing HT and core siblings of each logical CPU */
Let's change that to be more clear:
"representing all execution threads on a logical CPU, i.e. per physical socket"
or if someone has an even better formulation...
other than that:
Acked-by: Borislav Petkov <bp@alien8.de>
-- Regards/Gruss, Boris.
| |