Messages in this thread | | | Date | Mon, 20 Feb 2012 18:14:32 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH v2 3/3] i387: support lazy restore of FPU state |
| |
On 02/20/2012 06:10 PM, Linus Torvalds wrote: > On Mon, Feb 20, 2012 at 5:50 PM, Josh Boyer <jwboyer@gmail.com> wrote: >> >> I haven't tried really figuring this out yet, but building the Fedora kernel >> on x86_64 with your latest tree results in: >> >> ERROR: "fpu_owner_task" [lib/raid6/raid6_pq.ko] undefined! > > Ugh. My dislike of modules on my machines strikes again, and > apparently nobody else tested the patches I sent out. > > The attached trivial patch fixes it, I bet. > > Although I do wonder if we should just make kernel_fpu_begin() be a > real function instead of inlining it. I'm not sure it makes sense to > inline that thing, and it might be better to export that one instead. > Comments? >
I would agree with that.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |