Messages in this thread | | | Date | Mon, 20 Feb 2012 12:19:07 +0100 | From | Thomas Weber <> | Subject | Re: [PATCH 0/3] Small fixes for w1_bq27000 driver |
| |
Hello Neil,
thanks for the link to your git repo. I checked today with an oscilloscope and there were no communication between the omap and the battery. I then merged your whole hdq branch and now it works.
Thanks. Have to look, which commit makes it work.
Thomas
On 19.02.2012 08:06, NeilBrown wrote: > On Sun, 19 Feb 2012 07:50:23 +0100 Thomas Weber > <thomas.weber.linux@googlemail.com> wrote: > >> On 02/19/2012 03:10 AM, NeilBrown wrote: >>> The following three patches fix a problem with the w1 interface for >>> the bq27000 battery charge meter, and remove some unnecessary code. >>> >>> thanks, >>> NeilBrown >>> >>> >>> --- >>> >>> NeilBrown (3): >>> w1_bq27000: Only one thread can access the bq27000 at a time. >>> w1_bq27000 - remove w1_bq27000_write >>> w1_bq27000: remove unnecessary NULL test. >>> >>> >>> drivers/w1/slaves/w1_bq27000.c | 19 ++----------------- >>> 1 files changed, 2 insertions(+), 17 deletions(-) >>> >> Hello Neil, >> I have the following problem. The board not correctly reads the values >> from the bq27000. It also doesn't detects if the bq27000 is connected. I >> think it always reads 0xFF. >> >> Do you have an omap3 board and a bq27000 battery? > > Yes, I have an OMAP3 with the HDQ line connected to a battery with a bq27000 > in it. It now works fine. > > When I first started working on it I would sometimes get problems with lots > of 0xFF being read, usually with lots of delays. > > One problem was that during boot there would often be multiple threads > accessing the battery and tripping over each other. > The third patch of this set fixes that. > > The other problem was power saving issues in the OMAP3 drivers. These > we address with lots of help from Paul Walmsley. > > You can find my current set of HDQ patches here: > > http://neil.brown.name/git?p=gta04;a=shortlog;h=refs/heads/hdq > > (or git://neil.brown.name/gta04 hdq) > > Most of these are from Paul. > > Please let me know if they help. > > NeilBrown
| |