lkml.org 
[lkml]   [2012]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] TTY: fix PTY hangup vs close race
    On 02/20/2012 11:20 AM, Sasha Levin wrote:
    >> [*] Your dump reveals that the code fetches tty->driver_data (mov
    >> 0x428(%rdi),%rbx) and traps at a fetch of inode->i_sbm because inode is
    >> NULL (mov 0x28(%rbx),%rax).
    >
    > It actually looks even more complex than that. I reverted the patch
    > above, but still got the error. A quick bisection pointed me to
    > a50f724a432997321cabb6c9e665c28e34850f78.

    > Looks like reverting both actually solves the problem. Reverting just
    > one of them doesn't.

    Ah, I see. I suppose you have CONFIG_LEGACY_PTYS=y. I somehow overlooked
    that case.

    So both of them should be reverted in upstream:
    d3bda5298aad98c7a27678bdd0dd9d008ab9e685
    a50f724a432997321cabb6c9e665c28e34850f78

    thanks,
    --
    js
    suse labs


    \
     
     \ /
      Last update: 2012-02-20 12:17    [W:0.024 / U:1.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site