lkml.org 
[lkml]   [2012]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Regression: Revert "Bluetooth: use buffer priority to mark URB_ISO_ASAP flag"
    Hi!

    > This reverts commit b8aabfc92249b239c425da7e4ca85b7e4855e984.
    >
    > URB_ISO_ASAP may only be used with iso end points, but this patch was
    > attempting to use it with a bulk endpoint. When DEBUG is defined in
    > the USB stack, it checks for invalid flags and returns -EINVAL instead
    > of actually transmitting the data.
    >
    > Signed-off-by: Keith Packard <keithp@keithp.com>

    This patch fixes a regression, and it is not in 3.3.0-rc2.

    (And for the record I also believe that #ifdef debug should not
    introduce extra error returns. WARN_ON() should be enough. Don't break
    systems for people who try to be nice and enable debugging.)
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2012-02-02 11:53    [W:0.021 / U:29.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site