lkml.org 
[lkml]   [2012]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/5 v2] [GIT PULL] x86/jump label: Paranoid checks and 2 or 5 byte nops
On 02/02/2012 02:04 PM, Steven Rostedt wrote:
> commit 7bbd9688727dd30cd44b90b3c9c35f0f66af77ff
> Author: Steven Rostedt<srostedt@redhat.com>
> Date: Thu Feb 2 16:55:43 2012 -0500
>
> x86/jump labels: Handle initialization of enabled nops
>
> When jump labels are initialized at boot up, they are compared
> to the default_nop before switching to the ideal nop.
>
> But if a jump label is enabled by default on start up, the
> enabled code does not test against the default nop, only the
> ideal nop. But as this jump label has not been converted to the
> ideal nop, it fails the check, and will crash the box.
>
> The enabled path needs to be aware of initialization too.
>
> Reported-by: Ingo Molnar<mingo@elte.hu>
> Signed-off-by: Steven Rostedt<rostedt@goodmis.org>
>

Would it make more sense to keep track of three states:

"Default"
"Enabled"
"Disabled"

-?


\
 
 \ /
  Last update: 2012-02-02 23:09    [W:0.073 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site