lkml.org 
[lkml]   [2012]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH] pinctrl: pin configuration states
    Linus Walleij wrote at Wednesday, February 01, 2012 12:29 PM:
    > On Thu, Jan 19, 2012 at 8:03 PM, Stephen Warren <swarren@nvidia.com> wrote:
    ...
    > >> +     /*
    > >> +      * Make a copy of the config state array - string pointers will end up
    > > ...
    > >> +     pinconf_states = tmp;
    > >> +     pinconf_states_num += num_states;
    > >
    > > We need to allow multiple tables to be registered, for all the same
    > > reasons we do for the pinmux mapping table. This implementation only
    > > keeps the most recently registered table.
    >
    > ? beats me.
    >
    > Please check the code for how I realloc the tmp variable (in the v2
    > patch set), I cannot spot the problem. It was designed to allow exactly
    > multiple calls to add tables piece by piece.

    Sorry, I must have been asleep when I wrote that...

    I was expecting the implementation to copy each table separately and
    store them in a list (since this would allow easy dynamic removel of the
    entries too), hence when I saw the assignment to a single global, I
    assumed it was just over-writing it; I guess I didn't even look at the
    realloc above or noticed that it was assigning "tmp" not just the caller-
    supplied parameter:-(

    --
    nvpublic

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-02 19:45    [W:0.029 / U:59.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site