[lkml]   [2012]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Staging: driver usbip: Code cleanup
On Sun, Feb 19, 2012 at 05:48:39PM +0530, santosh prasad nayak wrote:
> Code cleanup: removed commented code of old style lock initilization

1) The patch is line wrapped so it doesn't apply. To test, save
your email as raw text. `cat raw_email.txt | git am`
Read Documentation/email-clients.txt.

2) The subject could be improved. Do a:
git log --pretty=oneline drivers/staging/usbip/stub_dev.c | head
to see the correct prefix to use.

3) Instead of "Code cleanup" choose a more descriptive name like
"Delete commented code."

4) Use your full name for the Signed-off-by line.

Please fix these and resend.

If you want, you can leave and off the CC list, because no one on
those lists care about trivial patches to the Staging tree.

dan carpenter

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2012-02-19 20:59    [W:0.035 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site