lkml.org 
[lkml]   [2012]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] drivers/video/backlight/lp855x_bl.c: fix setting initial value for max_brightness and brightness
From
Date
Current code does not always ensure
pdata->initial_brightness <= pdata->max_brightness <= MAX_BRIGHTNESS.
Fix it.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/backlight/lp855x_bl.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index d32c097..29a3af2 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -24,6 +24,7 @@

#define BUF_SIZE (20)
#define DEFAULT_BL_NAME "lcd-backlight"
+#define MAX_BRIGHTNESS 255

struct lp855x {
const char *chipid;
@@ -171,10 +172,14 @@ static int lp855x_backlight_register(struct lp855x *lp)
char *name = pdata->name ? : DEFAULT_BL_NAME;

props.type = BACKLIGHT_PLATFORM;
+
+ if (pdata->max_brightness > MAX_BRIGHTNESS)
+ pdata->max_brightness = MAX_BRIGHTNESS;
+ props.max_brightness = pdata->max_brightness;
+
+ if (pdata->initial_brightness > pdata->max_brightness)
+ pdata->initial_brightness = pdata->max_brightness;
props.brightness = pdata->initial_brightness;
- props.max_brightness =
- (pdata->max_brightness < pdata->initial_brightness) ?
- 255 : pdata->max_brightness;

bl = backlight_device_register(name, lp->dev, lp,
&lp855x_bl_ops, &props);
--
1.7.5.4




\
 
 \ /
  Last update: 2012-02-19 08:11    [W:0.037 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site