lkml.org 
[lkml]   [2012]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/5] Extcon: support multiple states at a device.
On Fri, Feb 10, 2012 at 03:40:36PM +0900, MyungJoo Ham wrote:

> + [EXTCON_AUDIO_IN] = "Audio-in",
> + [EXTCON_AUDIO_OUT] = "Audio-out",

Can I suggest making these more specific - how about

[EXTCON_LINE_IN] = "Line-in",
[EXTCON_LINE_OUT] = "Line-out",
[EXTCON_MIC_IN] = "Microphone",
[EXTCON_HEADPHONE_OUT] = "Headphone",

as a starting point? The distinction between line and the other two is
often pretty important from a UI/system interaction point of view.

> + /* TODO: remove before submit */
> + pr_info("[%s][%d]\n", buffer, enabled);

:)
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-02-20 03:27    [W:0.137 / U:24.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site