Messages in this thread | | | Date | Sat, 18 Feb 2012 13:39:47 +0300 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH 3/3] w1: add slave driver for DS1996 and DS1963L |
| |
Hi
On Fri, Feb 17, 2012 at 01:07:02PM +0100, Michael Thalmeier (michael.thalmeier@hale.at) wrote: > This driver adds support for some Dallas non-volatile memory 1-wire slave > devices. > > At the moment the following devices are supported: > > * family 0x0c: DS1996 64Kb Memory iButton > * family 0x1A: DS1963L 4kbit Monetary > > Access to memory is done via pages exportedi in sysfs. > > Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
Looks good to me, although I would replace config option with sysfs-enabled parameter, since distros do not compile different kernels with various options enabled.
-- Evgeniy Polyakov
| |