lkml.org 
[lkml]   [2012]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin
Date
On Saturday 18 February 2012 08:28:06 Danny Kukawka wrote:
> On Samstag, 18. Februar 2012, Joe Perches wrote:
> > On Fri, 2012-02-17 at 18:15 -0500, Mike Frysinger wrote:
> > > On Friday 17 February 2012 05:57:54 Danny Kukawka wrote:
> > > > Maybe. Many drivers already print information about setting a random
> > > > mac address to a netdevice. Some with printk, some via
> > > > netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum
> > > > methods. I could unify this, in a next step with a netdev_info in
> > > > eth_hw_addr_random(), if it's okay for David.
> > >
> > > i think unification in the core makes sense. it enforces consistency
> > > and removes duplication.
> >
> > It's a good idea.
>
> Okay ... I'll send a patch to print a message via netdev_info from
> eth_hw_addr_random() and to cleanup the drivers.

thanks!
-mike
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-02-19 03:51    [from the cache]
©2003-2011 Jasper Spaans