lkml.org 
[lkml]   [2012]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 01/10] au1000_eth: use eth_hw_addr_random() instead of random_ether_addr()
From
From: Danny Kukawka <danny.kukawka@bisect.de>
Date: Fri, 17 Feb 2012 16:43:22 +0100

> Use eth_hw_addr_random() instead of calling random_ether_addr()
> to set addr_assign_type correctly to NET_ADDR_RANDOM.
>
> v2: adapt to eth_hw_addr_random()
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>

Please don't shit up the comments:

> - /* set a random MAC now in case platform_data doesn't provide one */
...
> + /*set a random MAC since no valid provided by platform_data*/

You had to work to make that comment look worse than it originally
did in the code, spaces around the sentence and if you can be so
bothered capitalize sentences and put proper punctionation at the
end.

I took care of this, but I will not next time.


\
 
 \ /
  Last update: 2012-02-17 22:01    [W:0.121 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site