[lkml]   [2012]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gpiolib: Add comments explaining the _cansleep() WARN_ON()s
On Fri, Feb 17, 2012 at 07:41:33PM +0100, Linus Walleij wrote:
> On Fri, Feb 17, 2012 at 7:24 PM, Mark Brown

> > +       /* Should be using gpio_get_value_cansleep() or a different GPIO */
> >        WARN_ON(chip->can_sleep);

> Actually I cannot parse the "or a different GPIO" part.

> If this means that the user may be addressing the wrong GPIO pin,
> then we could spell that out I presume, but maybe you are referring
> to something else?

It was intended as a hint that if you really need to be in atomic
context to do whatever this isn't the GPIO for you but in retrospect
it's probably not actually useful advice for most users. I'll respin.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2012-02-17 19:47    [W:0.032 / U:1.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site