lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 5/6] introduce pmd_to_pte_t()
Date
On Wed, Feb 15, 2012 at 04:54:08PM -0800, Andrew Morton wrote:
> On Wed, 8 Feb 2012 10:51:41 -0500
> Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
>
> > Casting pmd into pte_t to handle thp is strongly architecture dependent.
> > This patch introduces a new function to separate this dependency from
> > independent part.
> >
> >
> > ...
> >
> > --- 3.3-rc2.orig/include/asm-generic/pgtable.h
> > +++ 3.3-rc2/include/asm-generic/pgtable.h
> > @@ -434,6 +434,10 @@ static inline int pmd_trans_splitting(pmd_t pmd)
> > {
> > return 0;
> > }
> > +static inline pte_t pmd_to_pte_t(pmd_t *pmd)
> > +{
> > + return 0;
> > +}
>
> This doesn't compile.

Sorry for my failing to make sure of compile testing.
The return value should be cast to pte_t to pass the complie.

> And I can't think of a sensible way of generating a stub for this
> operation - if you have a pmd_t and want to convert it to a pte_t then
> just convert it, dammit. And there's no rationality behind making that
> conversion unavailable or inoperative if CONFIG_TRANSPARENT_HUGEPAGE=n?
>
> Shudder. I'll drop the patch. Rethink, please.

OK for dropping it.
This patch is not enough to solve the problem of isolating arch dependency.

Although it's not clear from the name, the intension of this function was
to get the lowest level of entry in page table hierarchy which points to
a hugepage. It is pmd for x86_64, but pte for powerpc64 for example.
So I thought it's useful to introduce a stub like above.
But the callers of this function assume that pmd points to hugepage,
so arch dependency in arch independent code still remains.
We need to work on it when thp supports other archs,
but anyway, removing this patch is not critical for others of this series,
so I'm ok about it.


\
 
 \ /
  Last update: 2012-02-16 10:05    [W:0.066 / U:9.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site