lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] PCI: quirk print dev name with duration
From
Date
On Wed, 2012-02-15 at 21:43 -0800, Joe Perches wrote:
> On Wed, 2012-02-15 at 21:35 -0800, Yinghai Lu wrote:
> > On Wed, Feb 15, 2012 at 9:25 PM, Joe Perches <joe@perches.com> wrote:
> > > On Wed, 2012-02-15 at 21:14 -0800, Yinghai Lu wrote:
> > >> So could find out which device is involved with the calling
> > > []
> > >> +++ linux-2.6/drivers/pci/quirks.c
> > >> @@ -2854,14 +2854,15 @@ static void do_one_fixup_debug(void (*fn
> > >> ktime_t calltime, delta, rettime;
> > >> unsigned long long duration;
> > >>
> > >> - printk(KERN_DEBUG "calling %pF @ %i\n", fn, task_pid_nr(current));
> > >> + printk(KERN_DEBUG "calling %pF @ %i for %s\n",
> > >> + fn, task_pid_nr(current), dev_name(&dev->dev));
> > >
> > > Might be better to use dev_dbg
> > >
> > > dev_dbg(&dev->dev, "calling %pF @ %i\n", fn, task_pid_nr(current));
> > >
> > > []
> > >
> > >> - printk(KERN_DEBUG "pci fixup %pF returned after %lld usecs\n", fn,
> > >> - duration);
> > >> + printk(KERN_DEBUG "pci fixup %pF returned after %lld usecs for %s\n",
> > >> + fn, duration, dev_name(&dev->dev));
> > >
> > > dev_dbg(&dev->dev, "pci fixup %pF returned after %llu usecs\n",
> > > fn, duration);
> > Not sure if that is going to break Arjan 's tool that analyze the boot time.
> That depends on the tool code.
[]
> Do you have a link to the tool?

That tool would be scripts/bootgraph.pl and using
dev_dbg would break it unless it's adapted to the
change. Your change seems fine for now.




\
 
 \ /
  Last update: 2012-02-16 08:11    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean