Messages in this thread | | | Date | Wed, 15 Feb 2012 16:56:17 +0800 | Subject | Re: [PATCH v1] percpu: use raw_local_irq_* in _this_cpu op | From | Ming Lei <> |
| |
On Wed, Feb 15, 2012 at 2:03 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Le mercredi 15 février 2012 à 13:08 +0800, Ming Lei a écrit : > >> Just several warnings, no errors. Also the 5 warnings are introduced >> by previous commit, sounds nothing to do with motivation of this patch. >> You may prepare a standalone patch to fix all the code style in this file, :-) >> > > Oh well, I dont use checkpatch but spoke about trailing \ > > Cant you see them on your screen ? > > We had : > > #define _this_cpu_generic_to_op(pcp, val, op) \ > do { \ > unsigned long flags; \ > local_irq_save(flags); \ > *__this_cpu_ptr(&(pcp)) op val; \ > local_irq_restore(flags); \ > } while (0) > > > You want : > > #define _this_cpu_generic_to_op(pcp, val, op) \ > do { \ > unsigned long flags; \ > raw_local_irq_save(flags); \ > *__this_cpu_ptr(&(pcp)) op val; \ > raw_local_irq_restore(flags); \ > } while (0) > > > I suggest : > > #define _this_cpu_generic_to_op(pcp, val, op) \ > do { \ > unsigned long flags; \ > raw_local_irq_save(flags); \ > *__this_cpu_ptr(&(pcp)) op val; \ > raw_local_irq_restore(flags); \ > } while (0) > > > Is it clear now ?
Thanks for your pointing it out. Yes, I have updated the patch and sent it out.
thanks, -- Ming Lei
| |