lkml.org 
[lkml]   [2012]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] introduce pmd_to_pte_t()
On Wed,  8 Feb 2012 10:51:41 -0500
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:

> Casting pmd into pte_t to handle thp is strongly architecture dependent.
> This patch introduces a new function to separate this dependency from
> independent part.
>
>
> ...
>
> --- 3.3-rc2.orig/include/asm-generic/pgtable.h
> +++ 3.3-rc2/include/asm-generic/pgtable.h
> @@ -434,6 +434,10 @@ static inline int pmd_trans_splitting(pmd_t pmd)
> {
> return 0;
> }
> +static inline pte_t pmd_to_pte_t(pmd_t *pmd)
> +{
> + return 0;
> +}

This doesn't compile.

And I can't think of a sensible way of generating a stub for this
operation - if you have a pmd_t and want to convert it to a pte_t then
just convert it, dammit. And there's no rationality behind making that
conversion unavailable or inoperative if CONFIG_TRANSPARENT_HUGEPAGE=n?

Shudder. I'll drop the patch. Rethink, please.


\
 
 \ /
  Last update: 2012-02-16 01:57    [W:0.178 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site