Messages in this thread | | | Date | Wed, 15 Feb 2012 16:07:41 -0800 | From | Greg KH <> | Subject | Re: misc: hpilo patch for increasing max channels |
| |
On Wed, Oct 05, 2011 at 04:57:56PM +0100, Rusk, Mark wrote: > This patch is to allow for hpilo to support more channels (from 8 to 24) and this is configurable. > The module parameter, max_ccb, is also readable from /sys/module/hpilo/parameters/max_ccb. > > Signed-off-by: Mark Rusk <mark.rusk@hp.com> > > --- drivers/misc.old/hpilo.c 2011-10-04 17:37:59.000000000 -0500 > +++ drivers/misc/hpilo.c 2011-10-04 17:15:02.000000000 -0500
Please send patches that can be applied with 'patch -p1', as that is what our tools assume. Documentation/SubmittingPatches goes into this quite well.
> @@ -878,11 +883,14 @@ > class_destroy(ilo_class); > } > > -MODULE_VERSION("1.3"); > +MODULE_VERSION("1.2");
Why did you just decrement the module version?
Care to resend this in a format that I can apply it in, after verifying that you really want to go down in the module version number?
thanks,
greg k-h
| |