lkml.org 
[lkml]   [2012]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] i2c: Add Congatec CGEB I2C driver
On Tue, Feb 07, 2012 at 11:10:16AM +0100, Wolfram Sang wrote:
> Hi Sascha,
>
> > +config I2C_CONGATEC_CGEB
> > + tristate "Congatec CGEB I2C driver"
> > + depends on MFD_CONGATEC_CGEB
> > + help
> > + This driver provides support for the I2C busses accssable via
> > + the Congatec CGEB interface found on Congatec boards.
> > +
>
> Please keep the sorting (eg20t is wrong and will be fixed).
>
> > + ret = cgeb_call(priv->board, &fps, CgebI2CTransfer);
> > + if (ret) {
> > + ret = -EREMOTEIO;
> > + goto out;
> > + }
>
> -EREMOTEIO is not present in Documentation/i2c/fault-codes. Please use
> one from that file.

-EIO?

>
> > + ret = cgeb_i2c_set_speed(priv, 400000);
> > + if (ret)
> > + /*
> > + * not a critical error, we can continue with the default speed.
> > + */
> > + dev_warn(&pdev->dev, "Could not set speed to 400KHz\n");
>
> Is it possible to make this configurable? Not all I2C devices support
> 400KHz, 100KHz is OK.

Yes, it is. The problem is more *how* it should be configurable.
Exposing it via sysfs is the only reasonable option I can think
of.

Sascha

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2012-02-15 14:57    [from the cache]
©2003-2011 Jasper Spaans