Messages in this thread | | | Subject | Re: [tip:sched/core] sched: Turn lock_task_sighand() into a static inline | From | Peter Zijlstra <> | Date | Wed, 15 Feb 2012 14:52:48 +0100 |
| |
On Sat, 2012-02-11 at 15:10 -0800, tip-bot for Anton Vorontsov wrote: > +static inline struct sighand_struct *lock_task_sighand(struct task_struct *tsk, > + unsigned long *flags) > +{ > + struct sighand_struct *ret; > + > + ret = __lock_task_sighand(tsk, flags); > + (void)__cond_lock(&tsk->sighand->siglock, ret); > + return ret; > +}
FWIW, I still really utterly detest __cond_lock(). Ideally someone would teach sparse the conditional based on return thing and we could do the function level annotation.
| |