Messages in this thread | | | From | Yang Bai <> | Date | Tue, 14 Feb 2012 17:43:17 +0800 | Subject | Re: [PATCH] slab: warning if total alloc size overflow |
| |
On Tue, Feb 14, 2012 at 4:53 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Tue, 14 Feb 2012 15:28:19 +0800 Yang Bai <hamo.by@gmail.com> wrote: > > > One of the applications of kcalloc() is to prevent userspace from > causing a multiplicative overflow (and then perhaps causing an > overwrite beyond the end of the allocated memory). > > With this patch, we've just handed the user a way of spamming the logs > at 1MHz. This is bad. > > > Also, please let's not randomly add debug stuff in places where we've > never demonstrated a need for it.
Ok. Please just drop this patch.
Thanks.
-- """ Keep It Simple,Stupid. """
Chinese Name: 白杨 Nick Name: Hamo Homepage: http://hamobai.com/ GPG KEY ID: 0xA4691A33 Key fingerprint = 09D5 2D78 8E2B 0995 CF8E 4331 33C4 3D24 A469 1A33 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |