lkml.org 
[lkml]   [2012]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/6] usermodehelper: kill umh_wait, renumber UMH_* constants
    Date
    On Tue, 14 Feb 2012 17:48:21 +0100, Oleg Nesterov <oleg@redhat.com> wrote:
    > No functional changes. It is not sane to use UMH_KILLABLE with
    > enum umh_wait, but obviously we do not want another argument in
    > call_usermodehelper_* helpers. Kill this enum, use the plain int.

    Seems like a step backwards. Perhaps reorder the enum, but implying an
    explicit range of values explicit by using an enum seems good.

    But it's a minor gripe, feel free to ignore.

    Entire series:
    Acked-by: Rusty Russell <rusty@rustcorp.com.au>

    Thanks for this!
    Rusty.


    \
     
     \ /
      Last update: 2012-02-15 02:17    [W:0.020 / U:0.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site