lkml.org 
[lkml]   [2012]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Uninline kcalloc
    From
    Date
    On Feb 14, 2012, at 4:09 PM, Christoph Lameter wrote:
    > IMHO Having a function to deal with the overflow of a multiplication and
    > then do an allocation based on the result is a conflation of two different
    > things that need to be separate. kcalloc only exists because there is
    > an ancient user space function that somehow got a second parameter instead
    > of just using the same as malloc().

    I don't understand why these kcalloc patches have anything to do
    with kmalloc(SAFE_ARRAY_SIZE(...), ...) you proposed.

    It also doesn't make much sense to force the caller to check the
    result of SAFE_ARRAY_SIZE() or calculate_array_size() before passing
    it to kmalloc(). This is too verbose.

    - xi


    \
     
     \ /
      Last update: 2012-02-14 22:49    [W:0.029 / U:90.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site