Messages in this thread | | | Subject | Re: Uninline kcalloc | From | Xi Wang <> | Date | Tue, 14 Feb 2012 16:46:38 -0500 |
| |
On Feb 14, 2012, at 4:09 PM, Christoph Lameter wrote: > IMHO Having a function to deal with the overflow of a multiplication and > then do an allocation based on the result is a conflation of two different > things that need to be separate. kcalloc only exists because there is > an ancient user space function that somehow got a second parameter instead > of just using the same as malloc().
I don't understand why these kcalloc patches have anything to do with kmalloc(SAFE_ARRAY_SIZE(...), ...) you proposed.
It also doesn't make much sense to force the caller to check the result of SAFE_ARRAY_SIZE() or calculate_array_size() before passing it to kmalloc(). This is too verbose.
- xi
| |