Messages in this thread | | | Date | Tue, 14 Feb 2012 20:59:25 +0800 | Subject | Re: [ANNOUNCEMENT] The Barbershop Load Distribution algorithm for Linux kernel scheduler. | From | Hillf Danton <> |
| |
On Tue, Feb 14, 2012 at 1:22 AM, Rakib Mullick <rakib.mullick@gmail.com> wrote: >>> + >>> + if (rq->pos != 2) { /* if rq isn't the last one */ >>> + struct rq *last; >>> + write_lock_irqsave(&disp_list_lock, flag); >> >> if (rq->pos != 2) >> goto out; >> > At this point, we're checking whether this task is activating on a rq > which is the last (hightest loaded) rq or not. If rq->pos != 2, it > stands we're not activating a task at the highest loaded rq, so a > check will be made with the highest loaded rq to make sure - this rq's > loaded didn't exceed the highest loaded rq. If rq's load > exceed - list will be removed from it's place and will be placed as a > last entry of rq_head and thus it becomes the highest loaded rq. So, > what you proposed here isn't what was intended. >
I want to say if (rq->pos == 2) goto out; sorry for the bad:(
> Hiff, did you ran the patch? Would like to know.
Try to run soon.
Best regards Hillf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |