[lkml]   [2012]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 13/40] m32r: Use set_current_blocked() and block_sigmask()
    From: Matt Fleming <>

    As described in e6fa16ab ("signal: sigprocmask() should do
    retarget_shared_pending()") the modification of current->blocked is
    incorrect as we need to check whether the signal we're about to block
    is pending in the shared queue.

    Also, use the new helper function introduced in commit 5e6292c0f28f
    ("signal: add block_sigmask() for adding sigmask to current->blocked")
    which centralises the code for updating current->blocked after
    successfully delivering a signal and reduces the amount of duplicate
    code across architectures. In the past some architectures got this
    code wrong, so using this helper function should stop that from
    happening again.

    Cc: Oleg Nesterov <>
    Cc: Hirokazu Takata <>
    Cc: Al Viro <>
    Cc: Kyle McMartin <>
    Signed-off-by: Matt Fleming <>
    arch/m32r/kernel/signal.c | 12 ++----------
    1 files changed, 2 insertions(+), 10 deletions(-)

    diff --git a/arch/m32r/kernel/signal.c b/arch/m32r/kernel/signal.c
    index a08697f..f54d969 100644
    --- a/arch/m32r/kernel/signal.c
    +++ b/arch/m32r/kernel/signal.c
    @@ -112,10 +112,7 @@ sys_rt_sigreturn(unsigned long r0, unsigned long r1,
    goto badframe;

    sigdelsetmask(&set, ~_BLOCKABLE);
    - spin_lock_irq(&current->sighand->siglock);
    - current->blocked = set;
    - recalc_sigpending();
    - spin_unlock_irq(&current->sighand->siglock);
    + set_current_blocked(&set);

    if (restore_sigcontext(regs, &frame->uc.uc_mcontext, &result))
    goto badframe;
    @@ -300,12 +297,7 @@ handle_signal(unsigned long sig, struct k_sigaction *ka, siginfo_t *info,
    if (setup_rt_frame(sig, ka, info, oldset, regs))
    return -EFAULT;

    - spin_lock_irq(&current->sighand->siglock);
    - sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);
    - if (!(ka->sa.sa_flags & SA_NODEFER))
    - sigaddset(&current->blocked,sig);
    - recalc_sigpending();
    - spin_unlock_irq(&current->sighand->siglock);
    + block_sigmask(ka, sig);
    return 0;


     \ /
      Last update: 2012-02-14 12:45    [W:0.022 / U:33.812 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site