lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/i915: Fix single msg gmbus_xfers writes
On Mon, Feb 13, 2012 at 09:49:35PM +0000, Chris Wilson wrote:
> On Mon, 13 Feb 2012 21:38:38 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> > This here looks like just a white-space change. But your commit message
> > sounds like it's not jsut write's that are affected by this issue and need
> > to be fixed. Can you please clear up this for easily confused me?
>
> It makes the write path similar to the read path. I admit to overlooking
> the single write message as everything I saw was always a write followed
> by a read. The patch looks correct, but I need to stare at it a bit more
> before I r-b.
>
> However, the outstanding issue is that we need to separate the gmbus
> i2c adapter from the gpio i2c adapter in order for the pairing to work
> with the expectations of the i2c core.

There's another patch floating on dri-devel to add a gmbus_mutex. The
issue it tries to avoid is that multiple users corrupting each anothers
state when using the single gmbus controller. See "[PATCH] [PATCH]
drm/i915: Fix race condition in accessing GMBUS". Or have you thought of
another interaction that we need to sort out?
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48


\
 
 \ /
  Last update: 2012-02-13 23:29    [W:0.056 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site