lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] percpu: use raw_local_irq_* in _this_cpu op
On Mon, Feb 13, 2012 at 07:03:38PM +0800, Ming Lei wrote:
> It doesn't make sense to trace irq off or do irq flags
> lock proving inside 'this_cpu' operations, so replace local_irq_*
> with raw_local_irq_* in 'this_cpu' op.
>
> Also the patch fixes one lockdep warning[1], which is caused
> by the added local_irq_save/restore(flags) in this_cpu_inc
> called by __debug_atomic_inc: kernel/lockdep.c

I think this isn't gonna hurt anything but I don't understand why the
lockdep warning is triggering when using traced version. Can you
please explain that in a bit more detail in the patch description?

Thank you.

--
tejun


\
 
 \ /
  Last update: 2012-02-13 18:25    [from the cache]
©2003-2011 Jasper Spaans