lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] vfs: Provide function to get superblock and wait for it to thaw
On Sun 12-02-12 21:13:25, Al Viro wrote:
> On Fri, Feb 10, 2012 at 11:03:00AM +0100, Jan Kara wrote:
> > In quota code we need to find a superblock corresponding to a device and wait
> > for superblock to be unfrozen. However this waiting has to happen without
> > s_umount semaphore because that is required for superblock to thaw. So provide
> > a function in VFS for this to keep dances with s_umount where they belong.
>
> Eww... All it takes is
> struct super_block *get_super_thawed(struct block_device *bdev)
> {
> while (1) {
> struct super_block *s = get_super(bdev);
> if (!s || s->s_frozen == SB_UNFROZEN)
> return s;
> up_read(&s->s_umount);
> vfs_check_frozen(s, SB_FREEZE_WRITE);
> put_super(s);
> }
> }
> and there's no need of extra arguments, etc. whatsoever. Both patches
> applied, with implementation of get_super_thawed() done as above.
Yeah, this looks better. Thanks!

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2012-02-13 15:27    [W:0.240 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site