lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] drivers/leds/leds-lm3530.c: Move the code setting gen_config to one place
    From
    Date
    Improve the readability by moving the code setting gen_config to one place.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    drivers/leds/leds-lm3530.c | 18 ++++++++++--------
    1 files changed, 10 insertions(+), 8 deletions(-)

    diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
    index e59c166..af3f8b8 100644
    --- a/drivers/leds/leds-lm3530.c
    +++ b/drivers/leds/leds-lm3530.c
    @@ -158,9 +158,16 @@ static int lm3530_init_registers(struct lm3530_data *drvdata)
    gen_config = (pltfm->brt_ramp_law << LM3530_RAMP_LAW_SHIFT) |
    ((pltfm->max_current & 7) << LM3530_MAX_CURR_SHIFT);

    - if (drvdata->mode == LM3530_BL_MODE_MANUAL ||
    - drvdata->mode == LM3530_BL_MODE_ALS)
    - gen_config |= (LM3530_ENABLE_I2C);
    + switch (drvdata->mode) {
    + case LM3530_BL_MODE_MANUAL:
    + case LM3530_BL_MODE_ALS:
    + gen_config |= LM3530_ENABLE_I2C;
    + break;
    + case LM3530_BL_MODE_PWM:
    + gen_config |= LM3530_ENABLE_PWM | LM3530_ENABLE_PWM_SIMPLE |
    + (pltfm->pwm_pol_hi << LM3530_PWM_POL_SHIFT);
    + break;
    + }

    if (drvdata->mode == LM3530_BL_MODE_ALS) {
    if (pltfm->als_vmax == 0) {
    @@ -194,11 +201,6 @@ static int lm3530_init_registers(struct lm3530_data *drvdata)

    }

    - if (drvdata->mode == LM3530_BL_MODE_PWM)
    - gen_config |= (LM3530_ENABLE_PWM) |
    - (pltfm->pwm_pol_hi << LM3530_PWM_POL_SHIFT) |
    - (LM3530_ENABLE_PWM_SIMPLE);
    -
    brt_ramp = (pltfm->brt_ramp_fall << LM3530_BRT_RAMP_FALL_SHIFT) |
    (pltfm->brt_ramp_rise << LM3530_BRT_RAMP_RISE_SHIFT);

    --
    1.7.5.4




    \
     
     \ /
      Last update: 2012-02-13 14:15    [W:0.021 / U:151.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site