lkml.org 
[lkml]   [2012]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] firewire-sbp2: Ignore SBP-2 targets on the local node
On Feb 10 Chris Boot wrote:
> --- a/drivers/firewire/sbp2.c
> +++ b/drivers/firewire/sbp2.c
> @@ -1138,6 +1138,12 @@ static int sbp2_probe(struct device *dev)
> struct Scsi_Host *shost;
> u32 model, firmware_revision;
>
> + /* ignore targets on the local node */
> + if (device->node == device->card->local_node) {
> + dev_set_drvdata(&unit->device, NULL);
> + return 0;
> + }

I forgot: This test can yield false negatives because card->local_node
may change anytime. Check device->is_local instead.
--
Stefan Richter
-=====-===-- --=- -=-==
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2012-02-11 12:59    [W:0.076 / U:2.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site