lkml.org 
[lkml]   [2012]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Staging: bcm: Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()
On Fri, 10 Feb 2012, Greg KH wrote:

> On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> > From: Jesper Juhl <jj@codesealer.com>
> >
> > We allocate memory for 'pstAddIndication' with kmalloc() in
> > drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> > neglect to free it on a number of exit paths from that function.
> >
> > This could probably be resolved cleaner/nicer, but this file needs a
> > serious overhaul in any case, so I opted for just fixing the problem
> > as directly as I could and then we can clean it up generally
> > later... This at least makes it stop bleeding..
> >
> > Signed-off-by: Jesper Juhl <jj@codesealer.com>
>
> Odd, didn't I already apply this patch?
>
> confused,
>

Well, you were the one who (in email message with Message-ID:
<20120209175217.GA13959@kroah.com>) said that it no longer applied and
asked for a resubmit against linux-next:

"This patch no longer applies, care to redo it against the latest
linux-next tree?"

So I just did what you asked :-)

Whether or not you have already applied it somewhere else I have no
idea...

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2012-02-12 00:57    [W:0.095 / U:2.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site