lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 22/22] PCI: clean up rescan_bus_bridge_resize
    Date
    Should only use it with bridge instead of bus.
    it could get new subordinate. so can not use it with reguar bus.

    in that case, use may need to make all children devices get removed already.

    Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    ---
    drivers/pci/pci-sysfs.c | 7 ++-----
    1 files changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
    index 68caf29..a3fa64e 100644
    --- a/drivers/pci/pci-sysfs.c
    +++ b/drivers/pci/pci-sysfs.c
    @@ -337,7 +337,7 @@ dev_bridge_rescan_store(struct device *dev, struct device_attribute *attr,

    if (val) {
    mutex_lock(&pci_remove_rescan_mutex);
    - pci_rescan_bus(pdev->subordinate);
    + pci_rescan_bus_bridge_resize(pdev);
    mutex_unlock(&pci_remove_rescan_mutex);
    }
    return count;
    @@ -387,10 +387,7 @@ dev_bus_rescan_store(struct device *dev, struct device_attribute *attr,

    if (val) {
    mutex_lock(&pci_remove_rescan_mutex);
    - if (!pci_is_root_bus(bus) && list_empty(&bus->devices))
    - pci_rescan_bus_bridge_resize(bus->self);
    - else
    - pci_rescan_bus(bus);
    + pci_rescan_bus(bus);
    mutex_unlock(&pci_remove_rescan_mutex);
    }
    return count;
    --
    1.7.7


    \
     
     \ /
      Last update: 2012-02-11 05:11    [W:4.094 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site