lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 72/86] target: Fail INQUIRY commands with EVPD==0 but PAGE CODE!=0
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Roland Dreier <roland@purestorage.com>

    commit bf0053550aebe56f3bb5dd793e9de69238b5b945 upstream.

    My draft of SPC-4 says:

    If the PAGE CODE field is not set to zero when the EVPD bit is set
    to zero, the command shall be terminated with CHECK CONDITION
    status, with the sense key set to ILLEGAL REQUEST, and the
    additional sense code set to INVALID FIELD IN CDB.

    Signed-off-by: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/target/target_core_cdb.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/drivers/target/target_core_cdb.c
    +++ b/drivers/target/target_core_cdb.c
    @@ -701,6 +701,13 @@ int target_emulate_inquiry(struct se_tas
    int p, ret;

    if (!(cdb[1] & 0x1)) {
    + if (cdb[2]) {
    + pr_err("INQUIRY with EVPD==0 but PAGE CODE=%02x\n",
    + cdb[2]);
    + cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD;
    + return -EINVAL;
    + }
    +
    ret = target_emulate_inquiry_std(cmd);
    goto out;
    }



    \
     
     \ /
      Last update: 2012-02-11 00:11    [W:0.020 / U:0.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site