Messages in this thread | | | Date | Fri, 10 Feb 2012 17:53:31 -0500 | From | Don Zickus <> | Subject | Re: [PATCH 2/2] x86, reschedule: check to see if system is shutting down |
| |
On Fri, Feb 10, 2012 at 10:42:24PM +0000, Luck, Tony wrote: > - WARN_ON(1); > + if (atomic_read(&stopping_cpu) == -1) > + /* system is not shutting down.. yell */ > + WARN_ON(1); > > Should that be written as: > > /* system is not shutting down.. yell */ > WARN_ON(atomic_read(&stopping_cpu) == -1); > > the > if (something) > WARN_ON(1); > > looks weird.
Indeed. In my haste, I wrote some pretty sloppy code.
Thanks for catching that.
Cheers, Don
| |