lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86, reschedule: check to see if system is shutting down
On Fri, Feb 10, 2012 at 10:42:24PM +0000, Luck, Tony wrote:
> - WARN_ON(1);
> + if (atomic_read(&stopping_cpu) == -1)
> + /* system is not shutting down.. yell */
> + WARN_ON(1);
>
> Should that be written as:
>
> /* system is not shutting down.. yell */
> WARN_ON(atomic_read(&stopping_cpu) == -1);
>
> the
> if (something)
> WARN_ON(1);
>
> looks weird.

Indeed. In my haste, I wrote some pretty sloppy code.

Thanks for catching that.

Cheers,
Don


\
 
 \ /
  Last update: 2012-02-10 23:55    [W:0.026 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site