lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[09/21] udf: Mark LVID buffer as uptodate before marking it dirty
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit 853a0c25baf96b028de1654bea1e0c8857eadf3d upstream.

    When we hit EIO while writing LVID, the buffer uptodate bit is cleared.
    This then results in an anoying warning from mark_buffer_dirty() when we
    write the buffer again. So just set uptodate flag unconditionally.

    Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Cc: Dave Jones <davej@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/udf/super.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/fs/udf/super.c
    +++ b/fs/udf/super.c
    @@ -1791,6 +1791,12 @@ static void udf_open_lvid(struct super_b
    le16_to_cpu(lvid->descTag.descCRCLength)));

    lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag);
    + /*
    + * We set buffer uptodate unconditionally here to avoid spurious
    + * warnings from mark_buffer_dirty() when previous EIO has marked
    + * the buffer as !uptodate
    + */
    + set_buffer_uptodate(bh);
    mark_buffer_dirty(bh);
    sbi->s_lvid_dirty = 0;
    }



    \
     
     \ /
      Last update: 2012-02-10 23:53    [W:0.020 / U:90.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site